This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Allow for Solaris ld -V output on stdout
ClosedPublic

Authored by ro on Nov 3 2017, 8:55 AM.

Details

Summary

In recent versions of Solaris 11.4 (previously 12), ld -V output went to stdout instead
of stderr. Since AddLLVM.cmake only expects it on stderr, Solaris ld wasn't properly
detected and options not understood by it are passed during the build.

The following patch fixes this, allowing for both variants.

Tested on i386-pc-solaris2.11.4 (on top of D35755 which is needed for proper
Solaris support).

Diff Detail

Repository
rL LLVM

Event Timeline

ro created this revision.Nov 3 2017, 8:55 AM
ro added a comment.Nov 16 2017, 3:45 PM

ping^2

Anyone else who could review this? Thanks.

mgorny accepted this revision.Nov 17 2017, 12:17 AM

I don't see how this could break anything, and it's a pretty straightforward change.

This revision is now accepted and ready to land.Nov 17 2017, 12:17 AM
ro added a comment.Nov 17 2017, 12:24 AM

Great, thanks. Could you commit it for me?

This revision was automatically updated to reflect the committed changes.