This is an archive of the discontinued LLVM Phabricator instance.

Make DiagnosticIDs::getAllDiagnostics static.
ClosedPublic

Authored by leanil on Oct 27 2017, 7:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

xazax.hun edited edge metadata.Oct 30 2017, 3:17 AM

I like the idea of making functions that can be static, static. Could you update the usages of this function as well?

leanil updated this revision to Diff 121104.Nov 1 2017, 1:26 AM

Update usages of the function.
Checked with clang-tidy readability-static-accessed-through-instance.

This revision is now accepted and ready to land.Nov 13 2017, 3:06 AM
This revision was automatically updated to reflect the committed changes.