This is an archive of the discontinued LLVM Phabricator instance.

Differential D39118

[Mach-O] Fix incorrect symbol grouping for i386
AbandonedPublic

Authored by keith on Oct 20 2017, 3:48 AM.

Details

Reviewers
gellmar
Group Reviewers
lld
Summary

Fixes the mixed references to global functions
in the linked Mach-O file for i386 architecture

Diff Detail

Event Timeline

gellmar created this revision.Oct 20 2017, 3:48 AM
gellmar added a subscriber: • rafael.Oct 20 2017, 3:53 AM
gellmar retitled this revision from Mach-O: Fix incorrect symbol grouping for i386 to [Mach-O] Fix incorrect symbol grouping for i386.Oct 20 2017, 4:05 AM
• rafael edited subscribers, added: llvm-commits; removed: • rafael.Oct 20 2017, 9:00 AM
keith commandeered this revision.Jun 14 2023, 9:51 AM
keith added a reviewer: gellmar.
keith added a subscriber: keith.

closing as obsolete

Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 9:51 AM
keith abandoned this revision.Jun 14 2023, 9:51 AM

closing as obsolete

Revision Contents

PathSize
lib/
ReaderWriter/
MachO/
8 lines

Diff 119643

lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp

Context not available.
sout.sect = sin->n_sect; sout.sect = sin->n_sect;
sout.desc = sin->n_desc; sout.desc = sin->n_desc;
sout.value = sin->n_value; sout.value = sin->n_value;
if (sout.type == N_UNDF) if (sin->n_type & N_STAB)
f->stabsSymbols.push_back(sout);
else if (sout.type == N_UNDF)
f->undefinedSymbols.push_back(sout); f->undefinedSymbols.push_back(sout);
else if (sout.scope == (SymbolScope)N_EXT) else if (sin->n_type & N_EXT)
f->globalSymbols.push_back(sout); f->globalSymbols.push_back(sout);
else if (sin->n_type & N_STAB)
f->stabsSymbols.push_back(sout);
else else
f->localSymbols.push_back(sout); f->localSymbols.push_back(sout);
} }
Context not available.