This is an archive of the discontinued LLVM Phabricator instance.

[X86][SSE41][AVX] Update DPPD/DPPS instruction scheduling on btver2
ClosedPublic

Authored by avt77 on Oct 18 2017, 4:47 AM.

Details

Summary

This patch includes proper schedule some numbers for SSE 4.1 and AVX instructions on btver2 CPU.

Diff Detail

Repository
rL LLVM

Event Timeline

avt77 created this revision.Oct 18 2017, 4:47 AM
avt77 retitled this revision from SSE 4.1 instructions scheduling in btver2 to [X86][F16C] Update instruction scheduling on btver2.Oct 18 2017, 7:29 AM
avt77 retitled this revision from [X86][F16C] Update instruction scheduling on btver2 to [X86][SSE41] Update instruction scheduling on btver2.Oct 18 2017, 7:47 AM
RKSimon edited edge metadata.Oct 18 2017, 7:47 AM

I realise this was for SSE41 instructions, but given that its just dot product ops, it might be better to rename it and add the VDPPSY cases as well?

avt77 added a comment.Oct 19 2017, 7:36 AM

To rename as

[X86][SSE41][AVX] Update instruction scheduling on btver2

Is it OK?

avt77 updated this revision to Diff 119641.Oct 20 2017, 3:09 AM
avt77 retitled this revision from [X86][SSE41] Update instruction scheduling on btver2 to [X86][SSE41] [AVX]Update instruction scheduling on btver2.
avt77 edited the summary of this revision. (Show Details)

I added VDPPSY instructions scheduling.

To rename as

[X86][SSE41][AVX] Update instruction scheduling on btver2

Probably this would be best: "[X86][SSE41][AVX] Update DPPD/DPPS instruction scheduling on btver2"

lib/Target/X86/X86ScheduleBtVer2.td
379 ↗(On Diff #119641)

AMD docs says this should be [3,3] - go with that

386 ↗(On Diff #119641)

AMD docs says this should be [1,3,3] - go with that

avt77 updated this revision to Diff 119834.Oct 23 2017, 4:52 AM

Now all numbers are from AMD docs instead of agner ones.

avt77 retitled this revision from [X86][SSE41] [AVX]Update instruction scheduling on btver2 to [X86][SSE41][AVX] Update DPPD/DPPS instruction scheduling on btver2.Oct 23 2017, 4:53 AM
RKSimon accepted this revision.Oct 23 2017, 5:43 AM

LGTM - Please rebase to fix the SSE41-schedule diffs (test_extractps and test_pextrd) before commit

This revision is now accepted and ready to land.Oct 23 2017, 5:43 AM
This revision was automatically updated to reflect the committed changes.