This is an archive of the discontinued LLVM Phabricator instance.

[Support] Remove an outdated comment.
AcceptedPublic

Authored by ioeric on Oct 18 2017, 1:22 AM.

Details

Reviewers
pete
beanz
Summary

The comment about removeArgument seems to be outdated after
https://reviews.llvm.org/rL227345

I came across a use case where options only live in a function scope and need to
be unregistered before destruction, and It seems that removeArgument works
fine now after https://reviews.llvm.org/rL227345

Event Timeline

ioeric created this revision.Oct 18 2017, 1:22 AM
beanz accepted this revision.Nov 7 2017, 2:18 PM

LGTM. I am curious what your use case for adding and removing options is, can you elaborate?

This revision is now accepted and ready to land.Nov 7 2017, 2:18 PM