[ELF] - Cleanup of setReservedSymbolSections(). NFC.

[grimar]

Summary

I suggest following cleanup to avoid duplication and make code more readable.

[grimar]

Ping. Should I abandon it ?

[ruiu]

This patch doesn't seem to simplify code. I'd prefer the existing dumb but explicit code.

[grimar]

Ok, abandoning, though for me original code is harder to read.

ELF/Writer.cpp

if (P->p_type != PT_LOAD)
       continue;
     Last = P;
     if (P->p_flags & PF_W)
       LastRW = P;
     else
       LastRO = P;
   }
 
+  auto SetSection = [](ArrayRef<DefinedRegular *> V, OutputSection *OS) {
+    for (DefinedRegular *DR : V)
+      if (DR)
+        DR->Section = OS;
+  };
+
   // _end is the first location after the uninitialized data region.
-  if (Last) {
-    if (ElfSym::End1)
-      ElfSym::End1->Section = Last->LastSec;
-    if (ElfSym::End2)
-      ElfSym::End2->Section = Last->LastSec;
-  }
+  if (Last)
+    SetSection({ElfSym::End1, ElfSym::End2}, Last->LastSec);
 
   // _etext is the first location after the last read-only loadable segment.
-  if (LastRO) {
-    if (ElfSym::Etext1)
-      ElfSym::Etext1->Section = LastRO->LastSec;
-    if (ElfSym::Etext2)
-      ElfSym::Etext2->Section = LastRO->LastSec;
-  }
+  if (LastRO)
+    SetSection({ElfSym::Etext1, ElfSym::Etext2}, LastRO->LastSec);
 
   // _edata points to the end of the last non SHT_NOBITS section.
   if (LastRW) {
     size_t I = 0;
     for (; I < OutputSections.size(); ++I)
       if (OutputSections[I] == LastRW->FirstSec)
         break;
 
     for (; I < OutputSections.size(); ++I)
       if (OutputSections[I]->Type == SHT_NOBITS)
         break;
 
-    if (ElfSym::Edata1)
-      ElfSym::Edata1->Section = OutputSections[I - 1];
-    if (ElfSym::Edata2)
-      ElfSym::Edata2->Section = OutputSections[I - 1];
+    if (I > 0)
+      SetSection({ElfSym::Edata1, ElfSym::Edata2}, OutputSections[I - 1]);
   }
 
   if (ElfSym::Bss)
     ElfSym::Bss->Section = findSection(".bss");
 
   // Setup MIPS _gp_disp/__gnu_local_gp symbols which should
   // be equal to the _gp symbol's value.
   if (ElfSym::MipsGp) {