Add DK_Remark to SMDiagnostic
ClosedPublic

Authored by anemet on Thu, Oct 12, 4:48 PM.

Details

Summary

Swift uses SMDiagnostic for diagnostic messages. For
https://github.com/apple/swift/pull/12294, we need remark support.

I picked the color that clang uses to display them.

Diff Detail

Repository
rL LLVM
anemet created this revision.Thu, Oct 12, 4:48 PM

Seems reasonable to me. I don't know anything about the MIR parser's use of diagnostics, though.

Seems reasonable to me. I don't know anything about the MIR parser's use of diagnostics, though.

Currently it does not emit remarks and we can introduce remarks as needed. Thanks for the review!

This revision was automatically updated to reflect the committed changes.