Page MenuHomePhabricator

[compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

Authored by mgorny on Oct 12 2017, 1:47 AM.



Fix the gtest dependency to be included in DEPS only, rather than
in COMPILE_DEPS + DEPS. The former variable is apparently used to
provide unconditional dependencies, while the latter are only used
for non-standalone builds. Since they are concatenated, specifying gtest
in both is redundant. Furthermore, including it in COMPILE_DEPS causes
build failure for standalone builds where 'gtest' target is not present.

Diff Detail


Event Timeline

mgorny created this revision.Oct 12 2017, 1:47 AM

Yep, thanks! This was probably the root cause of the failure.

This revision is now accepted and ready to land.Oct 12 2017, 10:05 AM
This revision was automatically updated to reflect the committed changes.