This is an archive of the discontinued LLVM Phabricator instance.

[clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.
ClosedPublic

Authored by hokein on Oct 10 2017, 5:45 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Oct 10 2017, 5:45 AM
ioeric accepted this revision.Oct 10 2017, 6:48 AM

Lg with nits.

lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
163 ↗(On Diff #118362)

s/are known to/should be/ ?

166 ↗(On Diff #118362)

maybe "... for both symbol references and symbol definitions", just for clarity?

443 ↗(On Diff #118362)

nit: no braces

This revision is now accepted and ready to land.Oct 10 2017, 6:48 AM
hokein updated this revision to Diff 118573.Oct 11 2017, 2:38 AM
hokein marked 3 inline comments as done.

Address review comments.

This revision was automatically updated to reflect the committed changes.