This is an archive of the discontinued LLVM Phabricator instance.

[TablgeGen] : Tidy up CodeGenSchedule. NFC.
ClosedPublic

Authored by javed.absar on Oct 4 2017, 2:21 AM.

Details

Summary

Hi Matthias :

I am not sure if your permission for 'no-review needed for NFC/range changes etc' extended to TableGen. If so, I wont bother you with similar tablegen reviews in the future.

Diff Detail

Event Timeline

javed.absar created this revision.Oct 4 2017, 2:21 AM
MatzeB accepted this revision.Oct 4 2017, 11:02 AM

Sure feel free to also make such changes in tablegen without review. LGTM

utils/TableGen/CodeGenSchedule.cpp
588

Use a const reference here to avoid unnecessary copying.

This revision is now accepted and ready to land.Oct 4 2017, 11:02 AM
kparzysz added inline comments.
utils/TableGen/CodeGenSchedule.cpp
589

make_range is unnecessary for objects that have "begin" and "end".

695

Same here.

998

And here.

1018

And here.

1507

And here.

This revision was automatically updated to reflect the committed changes.