Hi Matthias :
I am not sure if your permission for 'no-review needed for NFC/range changes etc' extended to TableGen. If so, I wont bother you with similar tablegen reviews in the future.
Differential D38534
[TablgeGen] : Tidy up CodeGenSchedule. NFC. ClosedPublic Authored by javed.absar on Oct 4 2017, 2:21 AM.
Details Summary Hi Matthias : I am not sure if your permission for 'no-review needed for NFC/range changes etc' extended to TableGen. If so, I wont bother you with similar tablegen reviews in the future.
Diff Detail Event TimelineComment Actions Sure feel free to also make such changes in tablegen without review. LGTM
This revision is now accepted and ready to land.Oct 4 2017, 11:02 AM Closed by commit rL314982: [TablgeGen] : Tidy up CodeGenSchedule. NFC. (authored by javed.absar). · Explain WhyOct 5 2017, 6:29 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 117639 utils/TableGen/CodeGenSchedule.cpp
|
Use a const reference here to avoid unnecessary copying.