This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Get rid of precompiled input objects from testcases.
ClosedPublic

Authored by grimar on Oct 3 2017, 7:50 AM.

Details

Summary

We have verneed1.so and verneed2.so files + verneed.so.sh script
to produce them. They were committed long time ago when LLD
was not yet able to produce some sections for versioning
(".gnu.version_r" I think).

There is no point to have them as binaries anymore. Patch
creates asm inputs instead based on verneed.so.sh content.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Oct 3 2017, 7:50 AM
ruiu accepted this revision.Oct 3 2017, 4:26 PM

LGTM. Thank you for doing this.

test/ELF/verneed-as-needed-weak.s
2–3 ↗(On Diff #117528)

Swap these two lines because the second line does not depend on the first line.

test/ELF/verneed.s
2–3 ↗(On Diff #117528)

Ditto

This revision is now accepted and ready to land.Oct 3 2017, 4:26 PM
This revision was automatically updated to reflect the committed changes.