This is an archive of the discontinued LLVM Phabricator instance.

Differential D38385

Limit CFI blacklist entries to specific CFI mode
ClosedPublic

Authored by vlad.tsyrklevich on Sep 28 2017, 3:25 PM.

Details

Reviewers
eugenis
pcc
Commits
rGa0b02833bc5a: Limit CFI blacklist entries to specific CFI mode
rCRT315216: Limit CFI blacklist entries to specific CFI mode
rL315216: Limit CFI blacklist entries to specific CFI mode
Summary

Since D37924 and D37925 were merged, it's now possible to specify
individual sanitizers or CFI modes in sanitizer blacklists. Update the
CFI blacklist entries to only apply to cfi-unrelated-cast checks.

Diff Detail

Repository
rL LLVM

Event Timeline

vlad.tsyrklevich created this revision.Sep 28 2017, 3:25 PM
eugenis accepted this revision.Sep 28 2017, 5:18 PM
This revision is now accepted and ready to land.Sep 28 2017, 5:18 PM
Closed by commit rL315216: Limit CFI blacklist entries to specific CFI mode (authored by vlad.tsyrklevich). · Explain WhyOct 9 2017, 10:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
cfi/
1 line

Diff 118229

compiler-rt/trunk/lib/cfi/cfi_blacklist.txt

[cfi-unrelated-cast]
# std::get_temporary_buffer, likewise (libstdc++, libc++). # std::get_temporary_buffer, likewise (libstdc++, libc++).
fun:_ZSt20get_temporary_buffer* fun:_ZSt20get_temporary_buffer*
fun:_ZNSt3__120get_temporary_buffer* fun:_ZNSt3__120get_temporary_buffer*
# STL address-of magic (libstdc++, libc++). # STL address-of magic (libstdc++, libc++).
fun:*__addressof* fun:*__addressof*
fun:_ZNSt3__19addressof* fun:_ZNSt3__19addressof*
# Windows C++ stdlib headers that contain bad unrelated casts. # Windows C++ stdlib headers that contain bad unrelated casts.
src:*xmemory0 src:*xmemory0
src:*xstddef src:*xstddef
# std::_Sp_counted_ptr_inplace::_Sp_counted_ptr_inplace() (libstdc++). # std::_Sp_counted_ptr_inplace::_Sp_counted_ptr_inplace() (libstdc++).
# This ctor is used by std::make_shared and needs to cast to uninitialized T* # This ctor is used by std::make_shared and needs to cast to uninitialized T*
# in order to call std::allocator_traits<T>::construct. # in order to call std::allocator_traits<T>::construct.
fun:_ZNSt23_Sp_counted_ptr_inplace* fun:_ZNSt23_Sp_counted_ptr_inplace*