This depends on: D38310: [RISCV] Define RISC-V specific eflags
This is needed because lld testsuite uses yaml2obj/obj2yaml to assemble/disassemble ELF files (we can't use llvm-as/llvm-objdump as it is still far from complete).
Differential D38311
[RISCV] Parse RISC-V eflags in ObjectYAML PkmX on Sep 27 2017, 3:43 AM. Authored by
Details This depends on: D38310: [RISCV] Define RISC-V specific eflags This is needed because lld testsuite uses yaml2obj/obj2yaml to assemble/disassemble ELF files (we can't use llvm-as/llvm-objdump as it is still far from complete).
Diff Detail Event TimelineComment Actions Thanks. Implementation wise this looks good. Could you please add a test along the lines of test/Object/Mips/elf-flags.yaml? Comment Actions Are you able to add in an llvm-readobj test, just like the Mips elf-flags.yaml I referenced before? Comment Actions llvm-readobj would also need to be modified to recognize RISC-V eflags, and I think it is better to keep that in a separate commit. Comment Actions My mistake, I'd assumed incorrectly there was a little more code sharing going on here. Looks good to me. |