Page MenuHomePhabricator

[X86] Change the Format attribute for TEST*rr instruction from the default MRMDestReg to MRMSrcReg
AbandonedPublic

Authored by aymanmus on Sep 19 2017, 12:43 AM.

Details

Summary

Correctly define the TEST{8 | 16 | 32 | 64}rr instructions Format attribute.

Diff Detail

Event Timeline

aymanmus created this revision.Sep 19 2017, 12:43 AM
craig.topper edited edge metadata.Sep 20 2017, 7:28 PM

This is apparently a revert of the fix for https://bugs.llvm.org/show_bug.cgi?id=22995

What is the real right answer? What motivated this change?

Did this come out of the folding table work? The real bug is that TEST8rm is wrong. But we don't notice because we have aliases to accept the memory operand in either location.

aymanmus abandoned this revision.Oct 1 2017, 1:43 AM

Fixed in D38120