Page MenuHomePhabricator

[mips][microMIPS] Mark symbols as microMIPS if necessary
AbandonedPublic

Authored by zoran.jovanovic on May 15 2014, 5:52 AM.

Details

Reviewers
None
Summary

Implements marking of all necessary symbols as microMIPS.

Diff Detail

Event Timeline

zoran.jovanovic retitled this revision from to [mips][microMIPS] Mark symbols as microMIPS if necessary.
zoran.jovanovic updated this object.
zoran.jovanovic edited the test plan for this revision. (Show Details)
zoran.jovanovic added a reviewer: dsanders.

Provided context in patch.

dsanders edited edge metadata.Jun 11 2014, 8:36 AM

This needs to be reviewed on llvm-commits since it touches common code.

The obvious question is do we really need to change common code? We already subclass MCStreamer (see MipsELFStreamer), so could we override the things we need to there?

lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
236 ↗(On Diff #9437)

Use a range-based for loop.

zoran.jovanovic edited edge metadata.

New patch version that modifies MipsELFStreamer instead of using MCTargetStreamer methods.

sstankovic added inline comments.
lib/Target/Mips/MCTargetDesc/MipsELFStreamer.cpp
12

For one of my previous patches I received a comment that #includes should be sorted. So "llvm/MC/MCELF.h" should be placed before "llvm/MC/MCInst.h".

38

Type is unused.

lib/Target/Mips/MCTargetDesc/MipsELFStreamer.h
55

This line crosses the 80 columns limit. (There are other lines in the patch that also don't fit in 80 columns.)

dsanders resigned from this revision.Apr 17 2015, 3:41 AM
dsanders removed a reviewer: dsanders.

Resigning from review to remove it from my queue. It's an old patch and a similar change was committed.

zoran.jovanovic abandoned this revision.Feb 4 2016, 2:23 AM

Replaced by: