[libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX

[eduardo-elizondo]

Summary

On MacOSX the following program:

struct S { virtual void f() = delete; };
int main() { new S; }

Fails with the following error:

Undefined symbols for architecture x86_64:
  "___cxa_deleted_virtual"

This adds a fix to export the needed symbols.

Test:

> lit -sv test/libcxx/language.support/cxa_deleted_virtual.pass.cpp
> Testing Time: 0.21s
>   Expected Passes    : 1

Note: The first attempt to solve it is here: D36870. This adds the fix to just MacOSX files.

[EricWF]

Could you please add an entry into lib/abi/CHANGELOG.TXT, as well as a test that demonstrates the initial bug. I would put it under test/libcxx/language.support/cxa_deleted_virtual.pass.cpp.

Other than that, this LGTM.

[mclow.lists]

I agree with what @EricWF said - needs a test.
Also you should probably close D36870 with a note that this supersedes that one.

[eduardo-elizondo]

> lit -sv test/libcxx/language.support/cxa_deleted_virtual.pass.cpp
> Testing Time: 0.21s
>   Expected Passes    : 1

[eduardo-elizondo]

@EricWF will the final committer update the revision number in the Changelog?

[EricWF]

LGTM minus inline comments.

lib/abi/CHANGELOG.TXT

19

The revision will have to be updated afterwards with the commit ID that this eventually gets committed as; for now leave it as rTBD

test/libcxx/language.support/cxa_deleted_virtual.pass.cpp

10

This needs a // UNSUPPORTED: c++98, c++03 line.

[eduardo-elizondo]

Addressed inline comments.
Ran tests.

[eduardo-elizondo]

@EricWF would you be able to commit this for me?

[EricWF]

Committed as r313500.

lib/abi/CHANGELOG.TXT

 Version 5.0
 -----------
 
+* rTBD - Fix undefined "___cxa_deleted_virtual" symbol in macosx
+
+  x86_64-linux-gnu
+  ----------------
+  No changes
+
+  x86_64-apple-darwin16.0
+  -----------------------
+  Symbol added: ___cxa_deleted_virtual
+
 * r296729 - Remove std::num_get template methods which should be inline
 
   These functions should never have had visible definitions in the dylib but

lib/abi/x86_64-apple-darwin16.abilist

 {'type': 'I', 'is_defined': True, 'name': '___cxa_current_exception_type'}
 {'type': 'U', 'is_defined': False, 'name': '___cxa_current_primary_exception'}
 {'type': 'U', 'is_defined': False, 'name': '___cxa_decrement_exception_refcount'}
+{'type': 'U', 'is_defined': False, 'name': '___cxa_deleted_virtual'}
+{'type': 'I', 'is_defined': True, 'name': '___cxa_deleted_virtual'}
 {'type': 'U', 'is_defined': False, 'name': '___cxa_demangle'}
 {'type': 'I', 'is_defined': True, 'name': '___cxa_demangle'}
 {'type': 'U', 'is_defined': False, 'name': '___cxa_end_catch'}

lib/libc++abi.exp

 ___cxa_guard_release
 ___cxa_rethrow
 ___cxa_pure_virtual
+___cxa_deleted_virtual
 ___cxa_begin_catch
 ___cxa_throw
 ___cxa_vec_cctor

lib/libc++abi2.exp

 ___cxa_guard_release
 ___cxa_rethrow
 ___cxa_pure_virtual
+___cxa_deleted_virtual
 ___cxa_begin_catch
 ___cxa_throw
 ___cxa_vec_cctor

lib/libc++sjlj-abi.exp

 ___cxa_guard_release
 ___cxa_rethrow
 ___cxa_pure_virtual
+___cxa_deleted_virtual
 ___cxa_begin_catch
 ___cxa_throw
 ___cxa_vec_cctor

test/libcxx/language.support/cxa_deleted_virtual.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++98, c++03
+
+// Test exporting the symbol: "__cxa_deleted_virtual" in macosx
+
+struct S { virtual void f() = delete; };
+int main() { new S; }