Page MenuHomePhabricator

eduardo-elizondo (Eddie Elizondo)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 4:02 PM (108 w, 4 d)

Recent Activity

Sep 15 2017

eduardo-elizondo added a comment to D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

@EricWF would you be able to commit this for me?

Sep 15 2017, 6:22 AM

Sep 14 2017

eduardo-elizondo updated the diff for D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

Addressed inline comments.
Ran tests.

Sep 14 2017, 7:55 PM
eduardo-elizondo abandoned D36870: [libcxx] Add missing __cxa_deleted_virtual.

D37830 supersedes this change.

Sep 14 2017, 7:29 PM
eduardo-elizondo commandeered D36870: [libcxx] Add missing __cxa_deleted_virtual.
Sep 14 2017, 7:28 PM
eduardo-elizondo added a comment to D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.

@EricWF will the final committer update the revision number in the Changelog?

Sep 14 2017, 7:27 PM
eduardo-elizondo updated the diff for D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.
> lit -sv test/libcxx/language.support/cxa_deleted_virtual.pass.cpp
> Testing Time: 0.21s
>   Expected Passes    : 1
Sep 14 2017, 7:25 PM

Sep 13 2017

eduardo-elizondo updated the summary of D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.
Sep 13 2017, 2:51 PM
eduardo-elizondo created D37830: [libcxx] ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX.
Sep 13 2017, 2:49 PM
eduardo-elizondo added a comment to D36870: [libcxx] Add missing __cxa_deleted_virtual.

Any updates on this? I'm also hitting this bug.

Sep 13 2017, 12:01 PM

Aug 21 2017

eduardo-elizondo added a reviewer for D36946: [time-report] Add Template Instantiation Timer: vsk.
Aug 21 2017, 1:08 PM
eduardo-elizondo updated the diff for D36946: [time-report] Add Template Instantiation Timer.

Added timing to Function Instantiations as well

Aug 21 2017, 1:08 PM
eduardo-elizondo added a comment to D36946: [time-report] Add Template Instantiation Timer.

@eric_niebler You are right, we should also time: Sema::InstantiateFunctionDefinition

Aug 21 2017, 12:58 PM

Aug 20 2017

eduardo-elizondo added reviewers for D36946: [time-report] Add Template Instantiation Timer: eric_niebler, modocache.
Aug 20 2017, 8:09 PM
eduardo-elizondo updated the summary of D36946: [time-report] Add Template Instantiation Timer.
Aug 20 2017, 8:08 PM
eduardo-elizondo created D36946: [time-report] Add Template Instantiation Timer.
Aug 20 2017, 8:03 PM

Aug 18 2017

eduardo-elizondo added inline comments to D36492: [time-report] Add preprocessor timer.
Aug 18 2017, 1:52 PM