This is an archive of the discontinued LLVM Phabricator instance.

Differential D37823

Filenames are case-insensitive on Windows, so .DEF is the same as .def.
ClosedPublic

Authored by ruiu on Sep 13 2017, 1:10 PM.

Details

Reviewers
mstorsjo
Commits
rGb359263011f3: Filenames are case-insensitive on Windows, so .DEF is the same as .def.
rLLD313285: Filenames are case-insensitive on Windows, so .DEF is the same as .def.
rL313285: Filenames are case-insensitive on Windows, so .DEF is the same as .def.
Summary

Filenames are case-insensitive on Windows, so .DEF is the same as .def.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.Sep 13 2017, 1:10 PM
Harbormaster completed remote builds in B10198: Diff 115106.Sep 13 2017, 1:10 PM
mstorsjo accepted this revision.Sep 13 2017, 9:38 PM

LGTM

This revision is now accepted and ready to land.Sep 13 2017, 9:38 PM
Closed by commit rL313285: Filenames are case-insensitive on Windows, so .DEF is the same as .def. (authored by ruiu). · Explain WhySep 14 2017, 11:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
MinGW/
2 lines
test/
MinGW/
7 lines

Diff 115253

lld/trunk/MinGW/Driver.cpp

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Linesbool mingw::link(ArrayRef<const char *> ArgsArr, raw_ostream &Diag) {
for (auto *A : Args.filtered(OPT_L)) for (auto *A : Args.filtered(OPT_L))
SearchPaths.push_back(A->getValue()); SearchPaths.push_back(A->getValue());
StringRef Prefix = ""; StringRef Prefix = "";
bool Static = false; bool Static = false;
for (auto *A : Args) { for (auto *A : Args) {
switch (A->getOption().getUnaliasedOption().getID()) { switch (A->getOption().getUnaliasedOption().getID()) {
case OPT_INPUT: case OPT_INPUT:
if (StringRef(A->getValue()).endswith(".def")) if (StringRef(A->getValue()).endswith_lower(".def"))
Add("-def:" + StringRef(A->getValue())); Add("-def:" + StringRef(A->getValue()));
else else
Add(Prefix + StringRef(A->getValue())); Add(Prefix + StringRef(A->getValue()));
break; break;
case OPT_l: case OPT_l:
Add(Prefix + searchLibrary(A->getValue(), SearchPaths, Static)); Add(Prefix + searchLibrary(A->getValue(), SearchPaths, Static));
break; break;
case OPT_whole_archive: case OPT_whole_archive:
Show All 26 Lines

lld/trunk/test/MinGW/driver.test

Show All 20 Lines
ARM64-SAME: -machine:arm64 ARM64-SAME: -machine:arm64
ARM64-SAME: -alternatename:__image_base__=__ImageBase ARM64-SAME: -alternatename:__image_base__=__ImageBase
ARM64-SAME: foo.o ARM64-SAME: foo.o
RUN: ld.lld -### foo.o -m i386pep -shared | FileCheck -check-prefix=SHARED %s RUN: ld.lld -### foo.o -m i386pep -shared | FileCheck -check-prefix=SHARED %s
SHARED: -out:a.dll SHARED: -out:a.dll
SHARED-SAME: -dll SHARED-SAME: -dll
RUN: ld.lld -### foo.o -m i386pep -shared foo.def | FileCheck -check-prefix=DEF %s RUN: ld.lld -### foo.o -m i386pep -shared foo.def | FileCheck -check-prefix=DEF1 %s
DEF: -def:foo.def DEF1: -def:foo.def
RUN: ld.lld -### foo.o -m i386pep -shared FOO.DEF | FileCheck -check-prefix=DEF2 %s
DEF2: -def:FOO.DEF
RUN: ld.lld -### foo.o -m i386pep -o bar.exe | FileCheck -check-prefix=OUT %s RUN: ld.lld -### foo.o -m i386pep -o bar.exe | FileCheck -check-prefix=OUT %s
OUT: -out:bar.exe OUT: -out:bar.exe
RUN: ld.lld -### foo.o -m i386pep -e bar | FileCheck -check-prefix=ENTRY %s RUN: ld.lld -### foo.o -m i386pep -e bar | FileCheck -check-prefix=ENTRY %s
RUN: ld.lld -### foo.o -m i386pep --entry bar | FileCheck -check-prefix=ENTRY %s RUN: ld.lld -### foo.o -m i386pep --entry bar | FileCheck -check-prefix=ENTRY %s
ENTRY: -entry:bar ENTRY: -entry:bar
Show All 20 Lines