This is an archive of the discontinued LLVM Phabricator instance.

[X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang)

Authored by uriel.k on Sep 11 2017, 8:15 AM.

Diff Detail


Event Timeline

uriel.k created this revision.Sep 11 2017, 8:15 AM
craig.topper edited edge metadata.Sep 11 2017, 9:38 AM

Remove the builtins from BuiltinsX86.def

craig.topper requested changes to this revision.Sep 11 2017, 9:38 AM
This revision now requires changes to proceed.Sep 11 2017, 9:38 AM
uriel.k added a comment.EditedSep 12 2017, 12:15 AM

If I remove the builtins from the .def file this will not work, as I didn't replace the builtin call in the Header files but implemented the lowering by adding cases to the CGBuiltin.cpp and adding the IR by hand. Correct me if I'm wrong about this.

craig.topper accepted this revision.Sep 12 2017, 12:30 AM

Oops you are correct. Sorry.


This revision is now accepted and ready to land.Sep 12 2017, 12:30 AM
This revision was automatically updated to reflect the committed changes.