newest version of rc.exe (resource compiler) emits error with /nologo option.

[junryoungju]

Summary

Windows 10, Version 10.0.15063
using Windows SDK 10, new version of rc.exe(resource compiler) with Visual Studio 15 2017.

I gets rc1106: invalid option: -ologo

we can fix it just fixing cmake/modules/AddLLVM.cmake

set_property(SOURCE ${resource_file}
             PROPERTY COMPILE_FLAGS /nologo)

option to

set_property(SOURCE ${resource_file}
             PROPERTY COMPILE_FLAGS)

https://bugs.llvm.org/show_bug.cgi?id=33493

[junryoungju]

This comment was removed by junryoungju.

[junryoungju]

ping

[junryoungju]

Review this please. https://bugs.llvm.org/show_bug.cgi?id=33493

[rnk]

I have the latest rc.exe, and it supports /nologo:

$ where rc
C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x64\rc.exe
C:\Program Files (x86)\Windows Kits\10\bin\x64\rc.exe

$ rc -?

Microsoft (R) Windows (R) Resource Compiler Version 10.0.10011.16384
Copyright (C) Microsoft Corporation.  All rights reserved.

Usage:  rc [options] .RC input file
Switches:
...
   /nologo  Suppress startup logo

Where are you getting this rogue copy of rc.exe?

I'm passing /nologo to rc.exe and not getting this warning.

AddLLVM.cmake

318

Why would you check the C++ compiler version? That has little to nothing to do with the version of rc in use.

[junryoungju]

AddLLVM.cmake

318

https://bugs.llvm.org/show_bug.cgi?id=33493

see follow link.
its not that newest version of rc.ese does not supports /nologo, it glitches with /n option to it emits error.
so better fixing just not using /nologo with newest version. because it doesn't really needs on newest.

[junryoungju]

ping

[rnk]

AddLLVM.cmake

318

I have read that bug, and you didn't answer my questions. I suspect if I apply your patch locally, I will get the rc version banner, which is undesirable. My version of rc.exe is 10.0.10011.16384, and it doesn't have this problem.

AddLLVM.cmake

     set(ARG_PRODUCT_NAME "LLVM")
   endif()
 
+  if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+    if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 14.0)
+      set_property(SOURCE ${resource_file}
+                  PROPERTY COMPILE_FLAGS /nologo)
+    else ()
+      set_property(SOURCE ${resource_file}
+                  PROPERTY COMPILE_FLAGS)
+    endif()
+  endif()
   set_property(SOURCE ${resource_file}
-               PROPERTY COMPILE_FLAGS /nologo)
-  set_property(SOURCE ${resource_file}
                PROPERTY COMPILE_DEFINITIONS
                "RC_VERSION_FIELD_1=${ARG_VERSION_MAJOR}"
                "RC_VERSION_FIELD_2=${ARG_VERSION_MINOR}"