Page MenuHomePhabricator

[ASan tests] Add the first Windows-only lit test
ClosedPublic

Authored by timurrrr on May 14 2014, 8:54 AM.

Details

Reviewers
samsonov

Diff Detail

Event Timeline

timurrrr updated this revision to Diff 9393.May 14 2014, 8:54 AM
timurrrr retitled this revision from to [ASan tests] Add the first Windows-only lit test.
timurrrr updated this object.
timurrrr edited the test plan for this revision. (Show Details)
timurrrr added a reviewer: samsonov.
timurrrr added subscribers: Unknown Object (MLST), kcc.
timurrrr added inline comments.
test/asan/TestCases/Windows/thread_stack_array_left_oob.cc
3

Please note: I'm intentionally not filing and issue before I commit this patch to make it much easier for someone working on FileCheck to reproduce.
I'm afraid this issue exists only on Windows...

samsonov accepted this revision.May 14 2014, 11:01 AM
samsonov edited edge metadata.

w00t, glad to see this coming.

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc
1

Why 2>&1 here?

3

Okay... I would suggest to look at MemoryBuffer::getSTDIN() - FileCheck just uses LLVM libraries.

This revision is now accepted and ready to land.May 14 2014, 11:01 AM
timurrrr closed this revision.May 14 2014, 12:18 PM

r208802, thanks!

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc
1

Because ASan reports go to stderr? :)

samsonov added inline comments.May 14 2014, 12:40 PM
test/asan/TestCases/Windows/thread_stack_array_left_oob.cc
1

But this line doesn't run ASan executable, it's a compiler invocation.

2014-05-14 23:40 GMT+04:00 Alexey Samsonov <samsonov@google.com>:

+// RUN: %clangxx_asan -O0 %s -Fe%t 2>&1

> > Why 2>&1 here?

> Because ASan reports go to stderr? :)
But this line doesn't run ASan executable, it's a compiler invocation.

Oops! Probably a copy-n-paste mistake...
Fixed in r208805.