Page MenuHomePhabricator

Fix PR33878: BasicAA incorrectly assumes different address spaces don't alias
ClosedPublic

Authored by nlopes on Sep 6 2017, 7:41 AM.

Details

Summary

This fixes http://llvm.org/PR33878
This code assumes that a nullptr of address space != 0 cannot alias with a non-null pointer. This is incorrect, since nothing can be concluded about a null pointer in an address space != 0.
I trade down this code to revision r52299 (2008), before address spaces were introduced.

Diff Detail

Repository
rL LLVM

Event Timeline

nlopes created this revision.Sep 6 2017, 7:41 AM
hfinkel accepted this revision.Sep 6 2017, 8:27 AM
hfinkel added a subscriber: hfinkel.

LGTM

This revision is now accepted and ready to land.Sep 6 2017, 8:27 AM
davide accepted this revision.Sep 6 2017, 9:53 AM

lg, thanks.

This revision was automatically updated to reflect the committed changes.