Page MenuHomePhabricator

[CSA] Move AnalysisContext.h to AnalysisDeclContext.h
ClosedPublic

Authored by george.karpenkov on Sep 5 2017, 6:42 PM.

Details

Summary

The implementation is in AnalysisDeclContext.cpp and the class is called AnalysisDeclContext.

Making those match up has numerous benefits, including:

  • easier jump from header to/from implementation
  • easily identify filename from class

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ edited edge metadata.Sep 6 2017, 2:06 AM

Heh, i never noticed. Thanks.

include/clang/Analysis/AnalysisDeclContext.h
15–16 ↗(On Diff #113944)

Maybe rename those as well?

george.karpenkov marked an inline comment as done.

@NoQ done. There was also another file not matching up, I'll try to see whether I remember.

zaks.anna accepted this revision.Sep 6 2017, 1:21 PM

Looks good.

This revision is now accepted and ready to land.Sep 6 2017, 1:21 PM
This revision was automatically updated to reflect the committed changes.