Page MenuHomePhabricator

[Coverage] Report errors when reading malformed source regions
ClosedPublic

Authored by vsk on Sep 1 2017, 10:44 AM.

Details

Summary

Each source region has a start and end location. Report an error when
the end location does not precede the begin location.

The old lineExecutionCounts.covmapping test actually had a buggy source
region in it. This commit introduces a regenerated copy of the coverage
and moves the old copy to malformedRegions.covmapping, for a test.

This is needed to unblock D36813, since the proposed segment builder
changes assert-fail when given bogus input.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk created this revision.Sep 1 2017, 10:44 AM
ikudrin edited edge metadata.Sep 6 2017, 4:49 AM

It looks like Phabricator doesn't let me download binary files. But overall the patch looks good.

This revision was automatically updated to reflect the committed changes.