This is an archive of the discontinued LLVM Phabricator instance.

[ASan tests] Make simple pthread tests compile and pass on Windows
ClosedPublic

Authored by timurrrr on May 12 2014, 7:54 AM.

Details

Reviewers
kcc

Diff Detail

Event Timeline

timurrrr updated this revision to Diff 9311.May 12 2014, 7:54 AM
timurrrr retitled this revision from to [ASan tests] Make simple pthread tests compile and pass on Windows.
timurrrr updated this object.
timurrrr edited the test plan for this revision. (Show Details)
timurrrr added a reviewer: kcc.
timurrrr added a subscriber: Unknown Object (MLST).
kcc added inline comments.May 12 2014, 9:27 AM
lib/asan/tests/asan_test_utils.h
47

I'd prefer this code to be in a separate .h file included here.

61

maybe win32_pthread_foo ?

timurrrr updated this revision to Diff 9320.May 12 2014, 10:43 AM

Moved the pthread wrappers to sanitizer_common/tests, also restructured stuff a little bit

timurrrr added inline comments.May 12 2014, 10:44 AM
lib/asan/tests/asan_test_utils.h
47

Done -- and moved to sanitizer_common/tests as in fact we use pthread stuff in sanitizer tests too.

61

On the second thought, I think we don't need macros at all there?

kcc accepted this revision.May 13 2014, 12:35 AM
kcc edited edge metadata.

LGTM with a small nit

lib/sanitizer_common/tests/sanitizer_pthread_wrappers.h
66 ↗(On Diff #9320)

#endif // _WIN32

This revision is now accepted and ready to land.May 13 2014, 12:35 AM
timurrrr closed this revision.May 13 2014, 1:14 AM

Landed as r208674.