This is an archive of the discontinued LLVM Phabricator instance.

[X86AsmParser] Refactor AsmRewrite constructors, NFCI
ClosedPublic

Authored by krasimir on Aug 24 2017, 7:45 AM.

Reviewers

Commits

Summary

This is a follow-up of https://reviews.llvm.org/D37105, where a slight refactoring
of the constructors of AsmRewrite is proposed.

lgtm

This revision is now accepted and ready to land.Aug 24 2017, 7:50 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

include/

llvm/

MC/

MCParser/

4 lines

Show First 20 Lines • Show All 107 Lines • ▼ Show 20 Lines	struct AsmRewrite {
int64_t Val;		int64_t Val;
StringRef Label;		StringRef Label;
IntelExpr IntelExp;		IntelExpr IntelExp;

public:		public:
AsmRewrite(AsmRewriteKind kind, SMLoc loc, unsigned len = 0, int64_t val = 0)		AsmRewrite(AsmRewriteKind kind, SMLoc loc, unsigned len = 0, int64_t val = 0)
: Kind(kind), Loc(loc), Len(len), Val(val) {}		: Kind(kind), Loc(loc), Len(len), Val(val) {}
AsmRewrite(AsmRewriteKind kind, SMLoc loc, unsigned len, StringRef label)		AsmRewrite(AsmRewriteKind kind, SMLoc loc, unsigned len, StringRef label)
: Kind(kind), Loc(loc), Len(len), Val(0), Label(label) {}		: AsmRewrite(kind, loc, len) { Label = label; }
AsmRewrite(SMLoc loc, unsigned len, IntelExpr exp)		AsmRewrite(SMLoc loc, unsigned len, IntelExpr exp)
: Kind(AOK_IntelExpr), Loc(loc), Len(len), Val(0), IntelExp(exp) {}		: AsmRewrite(AOK_IntelExpr, loc, len) { IntelExp = exp; }
};		};

struct ParseInstructionInfo {		struct ParseInstructionInfo {
SmallVectorImpl<AsmRewrite> *AsmRewrites = nullptr;		SmallVectorImpl<AsmRewrite> *AsmRewrites = nullptr;

ParseInstructionInfo() = default;		ParseInstructionInfo() = default;
ParseInstructionInfo(SmallVectorImpl<AsmRewrite> *rewrites)		ParseInstructionInfo(SmallVectorImpl<AsmRewrite> *rewrites)
: AsmRewrites(rewrites) {}		: AsmRewrites(rewrites) {}
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines