This is an archive of the discontinued LLVM Phabricator instance.

ARMEB: Fix byte order of EH frame unwinding instructions
ClosedPublic

Authored by cpirker on May 9 2014, 8:58 AM.

Details

Reviewers
jmolloy
Summary

Hi all,

This patch outputs the unwinding instructions in section "ARM.extab" in endian aware order.
Please review.

Thanks,
Christian

Diff Detail

Event Timeline

cpirker updated this revision to Diff 9264.May 9 2014, 8:58 AM
cpirker retitled this revision from to ARMEB: Fix byte order of EH frame unwinding instructions.
cpirker updated this object.
cpirker edited the test plan for this revision. (Show Details)
cpirker added subscribers: Unknown Object (MLST), Konrad.
jmolloy accepted this revision.May 13 2014, 3:56 AM
jmolloy edited edge metadata.

Hi Christian,

I have some style nitpicks, but I'm happy for you to commit once those are fixed.

Cheers,

James

lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
1216

Style nitpicks: Spaces between operators and operands (x%4 -> x % 4, i+=4 -> i += 4), upper case I for loop induction variable.

This revision is now accepted and ready to land.May 13 2014, 3:56 AM
cpirker updated this revision to Diff 9343.May 13 2014, 4:22 AM
cpirker edited edge metadata.

Hi James,

I updated the patch in respect to your comments.

Thanks,
Christian

cpirker closed this revision.May 13 2014, 4:50 AM

I committed this patch as rL208689.