This is an archive of the discontinued LLVM Phabricator instance.

Differential D36594

[LLD] Don't install libraries when LLVM_INSTALL_TOOLCHAIN_ONLY is ON
Needs ReviewPublic

Authored by Eugene.Zelenko on Aug 10 2017, 2:43 PM.

Details

Reviewers
ruiu
• espindola
Summary

LLD currently installs libraries without respecting LLVM_INSTALL_TOOLCHAIN_ONLY. Installation depends on LLD_BUILD_TOOLS, but this variable is used in other places, so it could not be defaulted to NOT LLVM_INSTALL_TOOLCHAIN_ONLY.

Diff Detail

Event Timeline

Eugene.Zelenko created this revision.Aug 10 2017, 2:43 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 10 2017, 2:43 PM
• espindola edited reviewers, added: • espindola; removed: • rafael.Mar 15 2018, 9:11 AM

Revision Contents

PathSize
cmake/
modules/
2 lines

Diff 110635

cmake/modules/AddLLD.cmake

Context not available.
llvm_add_library(${name} ${ARG_ENABLE_SHARED} ${ARG_UNPARSED_ARGUMENTS}) llvm_add_library(${name} ${ARG_ENABLE_SHARED} ${ARG_UNPARSED_ARGUMENTS})
set_target_properties(${name} PROPERTIES FOLDER "lld libraries") set_target_properties(${name} PROPERTIES FOLDER "lld libraries")
if (LLD_BUILD_TOOLS) if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLD_BUILD_TOOLS)
if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
NOT LLVM_DISTRIBUTION_COMPONENTS) NOT LLVM_DISTRIBUTION_COMPONENTS)
set(export_to_lldtargets EXPORT lldTargets) set(export_to_lldtargets EXPORT lldTargets)
Context not available.