Page MenuHomePhabricator

[NewGVN] Add command-line option to control the generation of phi-of-ops (disable by default)
ClosedPublic

Authored by mcrosier on Aug 9 2017, 12:14 PM.

Details

Summary

Useful for testing and debugging. Disabled by default, per Danny's request.

Diff Detail

Event Timeline

mcrosier created this revision.Aug 9 2017, 12:14 PM
dberlin edited edge metadata.Aug 9 2017, 1:15 PM

I think where i come down on this is: disabled by default , and modify the existing test arguments to enable it, so that you don't have to xfail or modify a ton of tests :)
(then when it's fixed we can just remove the test arguments again).
But i'm also not opposed to doing the test updating.

mcrosier updated this revision to Diff 110476.Aug 9 2017, 2:03 PM
mcrosier edited the summary of this revision. (Show Details)

-Disable this feature by default.
-Update test RUN commands due to change.

mcrosier retitled this revision from [NewGVN] Add command-line option to control the generation of phi-of-ops. NFC. to [NewGVN] Add command-line option to control the generation of phi-of-ops (disable by default).Aug 9 2017, 2:03 PM
davide accepted this revision.Aug 10 2017, 12:44 AM
This revision is now accepted and ready to land.Aug 10 2017, 12:44 AM
mcrosier closed this revision.Aug 10 2017, 7:21 AM

r310594