Differential D36466

[ELF] - Do not omit common symbols when -Map is given.
ClosedPublic
Actions

Authored by grimar on Aug 8 2017, 7:00 AM.

Tags

None

Subscribers

Details

Reviewers

ruiu
• rafael

Commits

rGf2fe963d833e: [ELF] - Do not omit common symbols when -Map is given.
rLLD310703: [ELF] - Do not omit common symbols when -Map is given.
rL310703: [ELF] - Do not omit common symbols when -Map is given.

Summary

This is PR33886,

previously we did not output common symbols to map,
patch fixes that.

Diff Detail

Repository: rL LLVM

Event Timeline

grimar created this revision.Aug 8 2017, 7:00 AM

Herald added a subscriber: emaste. · View Herald TranscriptAug 8 2017, 7:00 AM

grimar edited the summary of this revision. (Show Details)Aug 8 2017, 7:00 AM

grimar mentioned this in D36468: [ELF] - Linkerscript: disallow discarding COMMON..Aug 8 2017, 8:50 AM

Added testcase.

ruiu added inline comments.Aug 10 2017, 5:55 AM

ELF/MapFile.cpp
40 ↗	(On Diff #110534)	Remove this typedef and inline.
61 ↗	(On Diff #110534)	Why do you have to check this?

grimar added inline comments.Aug 10 2017, 6:00 AM

ELF/MapFile.cpp
61 ↗	(On Diff #110534)	For -r/--no-define-common cases. Otherwise getSectionSyms() would return map with key==null, does not look clean an not useful (see my answer in this thread to Rafael about this place).

ruiu added inline comments.Aug 10 2017, 7:11 PM

test/ELF/map-commons.s
1 ↗	(On Diff #110534)	Remove this file because the feature is tested by map-file.s

Addressed comments.

LGTM

This revision is now accepted and ready to land.Aug 11 2017, 4:30 AM

Closed by commit rL310703: [ELF] - Do not omit common symbols when -Map is given. (authored by grimar). · Explain WhyAug 11 2017, 4:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lld/

trunk/

ELF/

49 lines

test/

ELF/

1 line

Diff 110686

lld/trunk/ELF/MapFile.cpp

Loading...

lld/trunk/test/ELF/map-file.s

Loading...