[Object] Fix ELFObjectFile<ELFT>::getRelocationOffset

[alexander-shaposhnikov]

Summary

The assert in ELFObjectFile<ELFT>::getRelocationOffset appears to be incorrect.
For example, dynamic libraries have e_type set to ET_DYN and contain relocations at the same time.
The same issue might arise for some executables (e_type set to ET_EXEC).

ELFObjectFile.h

ELFObjectFile<ELFT>::getRelocationSymbol(DataRefImpl Rel) const {
   DataRefImpl SymbolData;
   SymbolData.d.a = sec->sh_link;
   SymbolData.d.b = symbolIdx;
   return symbol_iterator(SymbolRef(SymbolData, this));
 }
 
 template <class ELFT>
 uint64_t ELFObjectFile<ELFT>::getRelocationOffset(DataRefImpl Rel) const {
-  assert(EF.getHeader()->e_type == ELF::ET_REL &&
-         "Only relocatable object files have relocation offsets");
   const Elf_Shdr *sec = getRelSection(Rel);
   if (sec->sh_type == ELF::SHT_REL)
     return getRel(Rel)->r_offset;
-
   return getRela(Rel)->r_offset;
 }
 
 template <class ELFT>
 uint64_t ELFObjectFile<ELFT>::getRelocationType(DataRefImpl Rel) const {
   const Elf_Shdr *sec = getRelSection(Rel);
   if (sec->sh_type == ELF::SHT_REL)
     return getRel(Rel)->getType(EF.isMips64EL());