[clang-tidy] Handle incomplete types in bugprone-undefined-memory-manipulation check.

[rnkovacs]

Summary

bugprone-undefined-memory-manipulation check crashes on incomplete types. This diff fixes that by assuming they are TriviallyCopyable by default.

[alexfh]

LG. Thank you for the fix!

clang-tools-extra/trunk/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp

 using namespace clang::ast_matchers;
 
 namespace clang {
 namespace tidy {
 namespace bugprone {
 
 namespace {
 AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
-  return !Node.isTriviallyCopyable();
+  // For incomplete types, assume they are TriviallyCopyable.
+  return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false;
 }
 } // namespace
 
 void UndefinedMemoryManipulationCheck::registerMatchers(MatchFinder *Finder) {
   const auto NotTriviallyCopyableObject =
       hasType(pointsTo(cxxRecordDecl(isNotTriviallyCopyable())));
 
   // Check whether destination object is not TriviallyCopyable.

clang-tools-extra/trunk/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp

 struct VirtualFunc {
   virtual void f() {}
 };
 
 struct VirtualBase : virtual Base {
   int vb;
 };
 
+// Incomplete type, assume it is TriviallyCopyable.
+struct NoDef;
+
+void f(NoDef *s) {
+  memset(s, 0, 5);
+}
+
 template <typename T>
 void memset_temp(T *b) {
   memset(b, 0, sizeof(T));
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: undefined behavior, destination object is not TriviallyCopyable [bugprone-undefined-memory-manipulation]
 }
 
 template <typename S, typename T>
 void memcpy_temp(S *a, T *b) {