Page MenuHomePhabricator

Work around an MSVC2017 update 3 codegen bug.
ClosedPublic

Authored by thakis on Jul 21 2017, 7:07 PM.

Details

Reviewers
rnk
Summary

MSVC2017 update 3 produces a clang that crashes when compiling clang. Disabling optimizations for StmtProfiler::VisitCXXOperatorCallExpr() makes the crash go away.

Patch from Bruce Dawson <brucedawson@chromium.org>!

Diff Detail

Event Timeline

thakis created this revision.Jul 21 2017, 7:07 PM
smeenai added inline comments.
lib/AST/StmtProfile.cpp
1367

Is it worth using _MSC_FULL_VER to limit this to Update 3 specifically?

From what I understand, _MSC_VER changes with each 2017 update.

rnk accepted this revision.Jul 24 2017, 9:25 AM

lgtm

This revision is now accepted and ready to land.Jul 24 2017, 9:25 AM
thakis closed this revision.Jul 24 2017, 9:55 AM

r308897.