This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Fuchsia defaults to -fno-math-errno
ClosedPublic

Authored by mcgrathr on Jul 21 2017, 4:26 PM.

Download Raw Diff

Details

Reviewers

Commits

rG67fe74b122ab: [Driver] Fuchsia defaults to -fno-math-errno
rC308855: [Driver] Fuchsia defaults to -fno-math-errno
rL308855: [Driver] Fuchsia defaults to -fno-math-errno

Diff Detail

Repository: rL LLVM

Event Timeline

mcgrathr created this revision.Jul 21 2017, 4:26 PM

test case

Please land it for me when approved.

LGTM

This revision is now accepted and ready to land.Jul 21 2017, 5:03 PM

mcgrathr added a subscriber: thakis.Jul 23 2017, 1:59 PM

Closed by commit rL308855: [Driver] Fuchsia defaults to -fno-math-errno (authored by phosek). · Explain WhyJul 23 2017, 3:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

lib/

Driver/

ToolChains/

Fuchsia.h

1 line

test/

Driver/

fast-math.c

2 lines

Diff 107845

cfe/trunk/lib/Driver/ToolChains/Fuchsia.h

	Show All 36 Lines

	class LLVM_LIBRARY_VISIBILITY Fuchsia : public ToolChain {			class LLVM_LIBRARY_VISIBILITY Fuchsia : public ToolChain {
	public:			public:
	Fuchsia(const Driver &D, const llvm::Triple &Triple,			Fuchsia(const Driver &D, const llvm::Triple &Triple,
	const llvm::opt::ArgList &Args);			const llvm::opt::ArgList &Args);

	bool HasNativeLLVMSupport() const override { return true; }			bool HasNativeLLVMSupport() const override { return true; }
	bool IsIntegratedAssemblerDefault() const override { return true; }			bool IsIntegratedAssemblerDefault() const override { return true; }
				bool IsMathErrnoDefault() const override { return false; }
	RuntimeLibType GetDefaultRuntimeLibType() const override {			RuntimeLibType GetDefaultRuntimeLibType() const override {
	return ToolChain::RLT_CompilerRT;			return ToolChain::RLT_CompilerRT;
	}			}
	CXXStdlibType GetDefaultCXXStdlibType() const override {			CXXStdlibType GetDefaultCXXStdlibType() const override {
	return ToolChain::CST_Libcxx;			return ToolChain::CST_Libcxx;
	}			}
	bool isPICDefault() const override { return false; }			bool isPICDefault() const override { return false; }
	bool isPIEDefault() const override { return true; }			bool isPIEDefault() const override { return true; }
	Show All 40 Lines

cfe/trunk/test/Driver/fast-math.c

	Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines
	// RUN: %clang -### -target x86_64-unknown-freebsd -c %s 2>&1 \			// RUN: %clang -### -target x86_64-unknown-freebsd -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -target x86_64-unknown-netbsd -c %s 2>&1 \			// RUN: %clang -### -target x86_64-unknown-netbsd -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -target x86_64-unknown-openbsd -c %s 2>&1 \			// RUN: %clang -### -target x86_64-unknown-openbsd -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -target x86_64-unknown-dragonfly -c %s 2>&1 \			// RUN: %clang -### -target x86_64-unknown-dragonfly -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
				// RUN: %clang -### -target x86_64-fuchsia -c %s 2>&1 \
				// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	//			//
	// Check that -ffast-math disables -fmath-errno, and -fno-fast-math merely			// Check that -ffast-math disables -fmath-errno, and -fno-fast-math merely
	// preserves the target default. Also check various flag set operations between			// preserves the target default. Also check various flag set operations between
	// the two flags. (Resuses above checks.)			// the two flags. (Resuses above checks.)
	// RUN: %clang -### -ffast-math -c %s 2>&1 \			// RUN: %clang -### -ffast-math -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -fmath-errno -ffast-math -c %s 2>&1 \			// RUN: %clang -### -fmath-errno -ffast-math -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	▲ Show 20 Lines • Show All 147 Lines • Show Last 20 Lines