[ELF] - Fix init_fini_priority.s test.

[grimar]

Summary

Previous output of readelf for object file used in test was:

[ 3] .init_array       INIT_ARRAY       0000000000000000  00000048
     0000000000000003  0000000000000000  WA       0     0     8
[ 4] .init_array.100   INIT_ARRAY       0000000000000000  0000004b
     0000000000000004  0000000000000000  WA       0     0     1
[ 5] .init_array.5     INIT_ARRAY       0000000000000000  0000004f
     0000000000000001  0000000000000000  WA       0     0     1

Problem is that .init_array sections were merged together.
I believe intention was different - test should show how separate
sections are correctly sorted. Patch makes such section to be unique.

[ruiu]

I don't understand the problem you are trying to fix. Looks like the test is correct to me. It verifies that .{init,fini}_array sections are sorted.

[grimar]

In D35552#816312, @ruiu wrote:

I don't understand the problem you are trying to fix. Looks like the test is correct to me. It verifies that .{init,fini}_array sections are sorted.

I do not think it was intended that test will have 6 input section in total: 3 .init_array and 3 .fini_array.
I believe intention was to create 10 input sections, or am I missing something ?

[ruiu]

What I don't really understand is that you changed the test input but didn't change the expected output, so this change doesn't demonstrate what was wrong and what it should have been.

[grimar]

In D35552#816422, @ruiu wrote:

What I don't really understand is that you changed the test input but didn't change the expected output, so this change doesn't demonstrate what was wrong and what it should have been.

I can add a check of llvm-mc output to validate that we have 5+5 input sections now and show initial order.
I did not do that because usually we do not check llvm-mc output, but only linker result which is the same with or without patch.

[grimar]

• Added check of sections that object contains.

[ruiu]

Ah, now I understood what you were trying to do. LGTM

lld/trunk/test/ELF/init_fini_priority.s

 // RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+// RUN: llvm-objdump -section-headers %t | FileCheck %s --check-prefix=OBJ
 // RUN: ld.lld %t -o %t.exe
 // RUN: llvm-objdump -s %t.exe | FileCheck %s
 // REQUIRES: x86
 
+// OBJ:       3 .init_array
+// OBJ-NEXT:  4 .init_array.100
+// OBJ-NEXT:  5 .init_array.5
+// OBJ-NEXT:  6 .init_array
+// OBJ-NEXT:  7 .init_array
+// OBJ-NEXT:  8 .fini_array
+// OBJ-NEXT:  9 .fini_array.100
+// OBJ-NEXT: 10 .fini_array.5
+// OBJ-NEXT: 11 .fini_array
+// OBJ-NEXT: 12 .fini_array
+
 .globl _start
 _start:
   nop
 
-.section .init_array, "aw", @init_array
+.section .init_array, "aw", @init_array, unique, 0
   .align 8
   .byte 1
 .section .init_array.100, "aw", @init_array
   .long 2
 .section .init_array.5, "aw", @init_array
   .byte 3
-.section .init_array, "aw", @init_array
+.section .init_array, "aw", @init_array, unique, 1
   .byte 4
-.section .init_array, "aw", @init_array
+.section .init_array, "aw", @init_array, unique, 2
   .byte 5
 
-.section .fini_array, "aw", @fini_array
+.section .fini_array, "aw", @fini_array, unique, 0
   .align 8
   .byte 0x11
 .section .fini_array.100, "aw", @fini_array
   .long 0x12
 .section .fini_array.5, "aw", @fini_array
   .byte 0x13
-.section .fini_array, "aw", @fini_array
+.section .fini_array, "aw", @fini_array, unique, 1
   .byte 0x14
-.section .fini_array, "aw", @fini_array
+.section .fini_array, "aw", @fini_array, unique, 2
   .byte 0x15
 
 // CHECK:      Contents of section .init_array:
 // CHECK-NEXT: 03020000 00000000 010405
 // CHECK:      Contents of section .fini_array:
 // CHECK-NEXT: 13120000 00000000 111415