Page MenuHomePhabricator

Second part of -Wcast-qual option enabling for OpenMP RTL code
ClosedPublic

Authored by AndreyChurbanov on Jul 14 2017, 8:15 AM.

Details

Summary

Previous patch r307020 has broken Windows build, mostly because changes were done in places of Linux compilers warnings without paying attention to Windows specific code.

This patch adds more consistency and also fixes the Windows build of the library.

  • all atomics now accept volatile pointer parameter; this allows to simplify a lot of type conversions.
  • NULL pointer value changed to nullptr in sensible places.
  • all 32-bit and 64-bit AND/OR atomics accept unsigned parameters (not only Unix specific that initial patch did).

Tried to build the library on Windows, and on Linux.

Diff Detail

Repository
rL LLVM

Event Timeline

This revision is now accepted and ready to land.Jul 14 2017, 12:42 PM
This revision was automatically updated to reflect the committed changes.