[LNT] "lnt profile upgrade" crashes when output points to an inexistent file

[leandron]

Summary

Regression when moving to "click" for command line parsing. "lnt profile upgrade" crashes when output points to an inexistent file. Also adds a test case.

So, this change:

• prevents click to check the path beforehand
• adds a test case to check "lnt profile upgrade" output to a new file

[cmatthews]

LGTM

[leandron]

@cmatthews Do you mind to commit this change for me as I don't have commit access yet ?

[leandron]

commited as r308230

lnt/lnttool/main.py

 @click.group("profile")
 def action_profile():
     """tools to extract information from profiles"""
     return
 
 
 @action_profile.command("upgrade")
 @click.argument("input", type=click.Path(exists=True))
[e-mail]("output", type=click.Path(exists=True))
[e-mail]("output", type=click.Path())
 def command_update(input, output):
     """upgrade a profile to the latest version"""
     import lnt.testing.profile.profile as profile
     profile.Profile.fromFile(input).upgrade().save(filename=output)
 
 
 @action_profile.command("getVersion")
 @click.argument("input", type=click.Path(exists=True))

tests/lnttool/Profile.py

 # RUN: lnt profile getVersion %S/Inputs/test.lntprof | FileCheck --check-prefix=CHECK-GETVERSION %s
 # CHECK-GETVERSION: 1
 
 # RUN: lnt profile getTopLevelCounters %S/Inputs/test.lntprof | FileCheck --check-prefix=CHECK-GETTLC %s
 # CHECK-GETTLC: {"cycles": 12345.0, "branch-misses": 200.0}
 
 # RUN: lnt profile getFunctions %S/Inputs/test.lntprof | FileCheck --check-prefix=CHECK-GETFUNCTIONS %s
 # CHECK-GETFUNCTIONS: {"fn1": {"length": 2, "counters": {"cycles": 45.0, "branch-misses": 10.0}}}
 
 # RUN: lnt profile getCodeForFunction %S/Inputs/test.lntprof fn1 | FileCheck --check-prefix=CHECK-GETFN1 %s
 # CHECK-GETFN1: [{}, 1048576, "add r0, r0, r0"], [{"cycles": 100.0}, 1048580, "sub r1, r0, r0"]]
+
+# RUN: mkdir -p %t
+# RUN: rm -rf %t/non_existing_output.lnt
+# RUN: lnt profile upgrade %S/Inputs/test.lntprof %t/non_existing_output.lnt
+# RUN: cat %t/non_existing_output.lnt