This is an archive of the discontinued LLVM Phabricator instance.

[PDB] Put LLD's PDB writing code in a class NFC
ClosedPublic

Authored by rnk on Jul 13 2017, 4:38 PM.

Details

Summary

We've accumulated about five or so data structures that are widely
referenced:

  • PDBBuilder
  • Type table
  • Id table
  • PDB string table
  • Type server handler

I'm about to rewrite type server handling, and I need a new class in LLD
where I can put its state. By creating a new PDBLinker class, I hope to
put it there next.

Event Timeline

rnk created this revision.Jul 13 2017, 4:38 PM
rnk updated this revision to Diff 106558.Jul 13 2017, 5:07 PM
  • fix lifetime issues
  • add commit method
ruiu accepted this revision.Jul 13 2017, 5:09 PM

LGTM

lld/COFF/PDB.cpp
537–538

You can remove llvm::.

This revision is now accepted and ready to land.Jul 13 2017, 5:09 PM
This revision was automatically updated to reflect the committed changes.