This is an archive of the discontinued LLVM Phabricator instance.

[coroutines] Add serialization/deserialization of coroutines
ClosedPublic

Authored by GorNishanov on Jul 13 2017, 1:29 PM.

Diff Detail

Event Timeline

GorNishanov created this revision.Jul 13 2017, 1:29 PM

@rsmith, ping. Would be good to get this in for clang 5.0

rsmith accepted this revision.Jul 24 2017, 12:32 PM
rsmith added inline comments.
lib/Serialization/ASTWriterStmt.cpp
320–321

Please call this ASTStmtWriter::VisitCoroutineSuspendExpr, following the pattern we use in the rest of this visitor.

This revision is now accepted and ready to land.Jul 24 2017, 12:32 PM

Thank you for the review. Feedback implemented. Preparing to land

This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
dongAxis1944 added inline comments.
cfe/trunk/lib/AST/StmtCXX.cpp
107–108 ↗(On Diff #108121)

hello, i have a question about that why clang commit info of parameters again in coroutine body?