Some programs run into a stack overflow issue. This change avoids this
problem by replacing the recursive algorithm with the iterative version.
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 8034 Build 8034: arc lint + arc unit
Event Timeline
Comment Actions
Looks good to me. Possible improvement below.
| lib/CodeGen/SjLjEHPrepare.cpp | ||
|---|---|---|
| 125–132 | Maybe for (BasicBlock *B : inverse_depth_first_ext(BB, LiveBBs)) {
/* Empty: We want to produce the visited set. */
}works as well? So we can leave out the first if and only need a single set. | |
Maybe
for (BasicBlock *B : inverse_depth_first_ext(BB, LiveBBs)) { /* Empty: We want to produce the visited set. */ }works as well? So we can leave out the first if and only need a single set.