[PATCH] Fix missing arguments to getType and getSymbol in Elf_Rel_Impl

[jakehehrlich]

Summary

Somehow this was compiling without these methods having their arguments passed to them. I used these methods in some code I wrote and it raised an error on me. It appears no one else has used these methods let (LLD uses setSymbolAndType however). This change resolves the issue.

As a curious question does anyone know how this was allowed to compile? I'm wondering weather this is a compiler bug. Every other method in these two specializations is used by some piece of code in LLVM/LLD. Shouldn't this have caused an error to be raised at compile time since these templates were fully instantiated?

[jakehehrlich]

I forgot to fix the other specialization as well.

llvm/trunk/include/llvm/Object/ELFTypes.h

struct Elf_Rel_Impl<ELFType<TargetEndianness, false>, false> {
   // and ELF32_R_INFO macros defined in the ELF specification:
   uint32_t getSymbol(bool isMips64EL) const {
     return this->getRInfo(isMips64EL) >> 8;
   }
   unsigned char getType(bool isMips64EL) const {
     return (unsigned char)(this->getRInfo(isMips64EL) & 0x0ff);
   }
   void setSymbol(uint32_t s, bool IsMips64EL) {
-    setSymbolAndType(s, getType(), IsMips64EL);
+    setSymbolAndType(s, getType(IsMips64EL), IsMips64EL);
   }
   void setType(unsigned char t, bool IsMips64EL) {
-    setSymbolAndType(getSymbol(), t, IsMips64EL);
+    setSymbolAndType(getSymbol(IsMips64EL), t, IsMips64EL);
   }
   void setSymbolAndType(uint32_t s, unsigned char t, bool IsMips64EL) {
     this->setRInfo((s << 8) + t, IsMips64EL);
   }
 };
 
 template <endianness TargetEndianness>
 struct Elf_Rel_Impl<ELFType<TargetEndianness, false>, true>
struct Elf_Rel_Impl<ELFType<TargetEndianness, true>, false> {
   // and ELF64_R_INFO macros defined in the ELF specification:
   uint32_t getSymbol(bool isMips64EL) const {
     return (uint32_t)(this->getRInfo(isMips64EL) >> 32);
   }
   uint32_t getType(bool isMips64EL) const {
     return (uint32_t)(this->getRInfo(isMips64EL) & 0xffffffffL);
   }
   void setSymbol(uint32_t s, bool IsMips64EL) {
-    setSymbolAndType(s, getType(), IsMips64EL);
+    setSymbolAndType(s, getType(IsMips64EL), IsMips64EL);
   }
   void setType(uint32_t t, bool IsMips64EL) {
-    setSymbolAndType(getSymbol(), t, IsMips64EL);
+    setSymbolAndType(getSymbol(IsMips64EL), t, IsMips64EL);
   }
   void setSymbolAndType(uint32_t s, uint32_t t, bool IsMips64EL) {
     this->setRInfo(((uint64_t)s << 32) + (t & 0xffffffffL), IsMips64EL);
   }
 };
 
 template <endianness TargetEndianness>
 struct Elf_Rel_Impl<ELFType<TargetEndianness, true>, true>