This is an archive of the discontinued LLVM Phabricator instance.

[X86] Convert CodeGen test half.ll to be update_llc_test_checks friendly. NFC.
ClosedPublic

Authored by gadi.haber on Jul 2 2017, 6:20 AM.

Details

Summary

Made some updates to the half.ll test under CodeGen to make it friendly to the update_llc_test_checks .py tool as follows:

  1. Removing the llc flag -asm-verbose=false
  2. Grouping the multiple check-prefix directives
  3. Apply update_llc_test_checks.py tool on the test

This change is needed to easily update scheduling changes in an upcoming patch.

Diff Detail

Repository
rL LLVM

Event Timeline

gadi.haber created this revision.Jul 2 2017, 6:20 AM
RKSimon added inline comments.Jul 3 2017, 4:08 AM
test/CodeGen/X86/half.ll
2 ↗(On Diff #105028)

You should be able to drop both the -march and the -mcpu from these tests - just use -mtriple and -mattr

273 ↗(On Diff #105028)

Keep this comment?

gadi.haber marked 2 inline comments as done.Jul 3 2017, 12:50 PM
gadi.haber updated this revision to Diff 105114.Jul 3 2017, 1:00 PM

Updated diff file after fixing comments provided by Simon.

RKSimon added inline comments.Jul 3 2017, 1:41 PM
test/CodeGen/X86/half.ll
273 ↗(On Diff #105028)

The comment is still missing

gadi.haber marked an inline comment as done.

Updated diff after adding back a comment related to test_floatret function.

RKSimon accepted this revision.Jul 4 2017, 7:51 AM

LGTM

This revision is now accepted and ready to land.Jul 4 2017, 7:51 AM
Closed by commit rL307108 (authored by gadi.haber). · Explain WhyJul 4 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.