respect target.x86-disassembly-flavor when using `memory read`

[crowell]

Summary

in DataDumpExtractor, respect the disassembly flavor, useful for using x/i (gdb-style) or memory read --format instruction

(lldb) x/i $pc
->  0x1000013fe: 48 c7 85 50 fb ff ff 00 00 00 00  movq   $0x0, -0x4b0(%rbp)
(lldb) settings set target.x86-disassembly-flavor intel
(lldb) x/i $pc
->  0x1000013fe: 48 c7 85 50 fb ff ff 00 00 00 00  mov    qword ptr [rbp - 0x4b0], 0x0

instead of how it was previously

(lldb) x/i $pc
->  0x1000013fe: 48 c7 85 50 fb ff ff 00 00 00 00  movq   $0x0, -0x4b0(%rbp)
(lldb) settings set target.x86-disassembly-flavor intel
(lldb) x/i $pc
->  0x1000013fe: 48 c7 85 50 fb ff ff 00 00 00 00  movq   $0x0, -0x4b0(%rbp)

[labath]

looks good

[jasonmolenda]

I committed this for Jeffrey in r307618.

source/Core/DumpDataExtractor.cpp

       target_sp = exe_scope->CalculateTarget();
     if (target_sp) {
       DisassemblerSP disassembler_sp(Disassembler::FindPlugin(
-          target_sp->GetArchitecture(), nullptr, nullptr));
+          target_sp->GetArchitecture(),
+          target_sp->GetDisassemblyFlavor(), nullptr));
       if (disassembler_sp) {
         lldb::addr_t addr = base_addr + start_offset;
         lldb_private::Address so_addr;