[ORE] Remove old "diagnostic hotness" spelling

[modocache]

Summary

Depends on https://reviews.llvm.org/D34865.

With the Clang uses of the old spelling having been removed in
https://reviews.llvm.org/D34865, get rid of the old "diagnostic hotness"
spellings in favor of the new "diagnostics hotness".

[anemet]

LGTM, thanks!

include/llvm/IR/LLVMContext.h

public:
   /// setDiagnosticHandler.
   DiagnosticHandlerTy getDiagnosticHandler() const;
 
   /// getDiagnosticContext - Return the diagnostic context set by
   /// setDiagnosticContext.
   void *getDiagnosticContext() const;
 
   /// \brief Return if a code hotness metric should be included in optimization
-  /// diagnostics. This method is deprecated; use getDiagnosticsHotnessRequested
-  /// instead.
-  bool getDiagnosticHotnessRequested() const;
-  /// \brief Set if a code hotness metric should be included in optimization
-  /// diagnostics. This method is deprecated; use setDiagnosticsHotnessRequested
-  /// instead.
-  void setDiagnosticHotnessRequested(bool Requested);
-
-  /// \brief Return if a code hotness metric should be included in optimization
   /// diagnostics.
   bool getDiagnosticsHotnessRequested() const;
   /// \brief Set if a code hotness metric should be included in optimization
   /// diagnostics.
   void setDiagnosticsHotnessRequested(bool Requested);
 
   /// \brief Return the YAML file used by the backend to save optimization
   /// diagnostics.  If null, diagnostics are not saved in a file but only

lib/IR/LLVMContext.cpp

 void LLVMContext::setDiagnosticHandler(DiagnosticHandlerTy DiagnosticHandler,
                                        void *DiagnosticContext,
                                        bool RespectFilters) {
   pImpl->DiagnosticHandler = DiagnosticHandler;
   pImpl->DiagnosticContext = DiagnosticContext;
   pImpl->RespectDiagnosticFilters = RespectFilters;
 }
 
-void LLVMContext::setDiagnosticHotnessRequested(bool Requested) {
-  pImpl->DiagnosticsHotnessRequested = Requested;
-}
-bool LLVMContext::getDiagnosticHotnessRequested() const {
-  return pImpl->DiagnosticsHotnessRequested;
-}
-
 void LLVMContext::setDiagnosticsHotnessRequested(bool Requested) {
   pImpl->DiagnosticsHotnessRequested = Requested;
 }
 bool LLVMContext::getDiagnosticsHotnessRequested() const {
   return pImpl->DiagnosticsHotnessRequested;
 }
 
 yaml::Output *LLVMContext::getDiagnosticsOutputFile() {