Page MenuHomePhabricator

[Data formatters] Make NSSetM support both old- and new-style representation
ClosedPublic

Authored by spyffe on Jun 29 2017, 11:03 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

spyffe created this revision.Jun 29 2017, 11:03 AM
jasonmolenda accepted this revision.Jun 29 2017, 2:36 PM

Good use of templates, looks good to me.

This revision is now accepted and ready to land.Jun 29 2017, 2:36 PM
lhames accepted this revision.Jun 29 2017, 4:53 PM

Otherwise LGTM. :)

source/Plugins/Language/ObjC/NSSet.cpp
134–135 ↗(On Diff #104695)

I think we prefer using to typedef these days.

153–154 ↗(On Diff #104695)

Ditto here.

This revision was automatically updated to reflect the committed changes.