Page MenuHomePhabricator

[clang-format] Fix parsing of msg{field}-style proto options
ClosedPublic

Authored by krasimir on Jun 28 2017, 6:54 AM.

Details

Summary

This patch makes the { in msg_field{field: OK} in a proto option scope be
treated as an assignment operator. Previosly the added test case was formatted
as:

option (MyProto.options) = {
  field_a: OK
  field_b{field_c: OK} field_d: OKOKOK field_e: OK
}

Diff Detail

Repository
rL LLVM

Event Timeline

krasimir created this revision.Jun 28 2017, 6:54 AM
krasimir updated this revision to Diff 104410.Jun 28 2017, 7:01 AM
  • Add a msg<field>-style test too

I think this is ready for a review.

djasper accepted this revision.Jun 29 2017, 4:56 AM

Looks good.

This revision is now accepted and ready to land.Jun 29 2017, 4:56 AM
This revision was automatically updated to reflect the committed changes.