This is an archive of the discontinued LLVM Phabricator instance.

Add sample PGO integration test to cover profile annotation and inlining.
ClosedPublic

Authored by danielcdh on Jun 27 2017, 4:37 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

danielcdh created this revision.Jun 27 2017, 4:37 PM
davidxl added inline comments.Jun 29 2017, 2:11 PM
test/CodeGen/pgo-sample.c
4 ↗(On Diff #104311)

using a a negative threshold to make sure regular inline heuristic does not kick in?

Also how about new PM?

28 ↗(On Diff #104311)

SHould this be 'CHECK-NOT: call' as bar is also inlined?

danielcdh updated this revision to Diff 105705.Jul 7 2017, 2:50 PM
danielcdh marked an inline comment as done.

Integrate David's comment and add new PM test.

danielcdh added inline comments.Jul 7 2017, 2:52 PM
test/CodeGen/pgo-sample.c
28 ↗(On Diff #104311)

There is still call to baz. Explicitly added CHECK-NOT call bar.

davidxl accepted this revision.Jul 7 2017, 2:57 PM

lgtm

This revision is now accepted and ready to land.Jul 7 2017, 2:57 PM
danielcdh closed this revision.Jul 7 2017, 3:02 PM
This revision is now accepted and ready to land.Jul 7 2017, 3:42 PM
This revision was automatically updated to reflect the committed changes.