Page MenuHomePhabricator

[TableGen] Improve Debug Output for --debug-only=subtarget-emitter NFCI
ClosedPublic

Authored by joelkevinjones on Jun 27 2017, 3:37 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

joelkevinjones created this revision.Jun 27 2017, 3:37 PM
MatzeB accepted this revision.Jun 27 2017, 3:45 PM
MatzeB added a subscriber: MatzeB.

Sure, LGTM.

utils/TableGen/CodeGenSchedule.cpp
548 ↗(On Diff #104284)

Add DEBUG()

This revision is now accepted and ready to land.Jun 27 2017, 3:45 PM
joelkevinjones added inline comments.Jun 27 2017, 5:00 PM
utils/TableGen/CodeGenSchedule.cpp
548 ↗(On Diff #104284)

Not needed here, as everything after the "if" statement on line 545 to the end of the method only executes if in DEBUG mode. Not necessarily the style I would use, but it does follow what the rest of the file does.

MatzeB added inline comments.Jun 27 2017, 5:01 PM
utils/TableGen/CodeGenSchedule.cpp
548 ↗(On Diff #104284)

ok, makes sense.

This revision was automatically updated to reflect the committed changes.