This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen][ObjC] Load indirect ARC arguments in prolog
ClosedPublic

Authored by kastiglione on Jun 23 2017, 4:31 PM.

Reviewers

compnerd
rnk

Summary

When generating a prolog, add loads for ARC arguments passed indirectly.

Build Status

Buildable 7609
Build 7609: arc lint + arc unit

lgtm

test/CodeGenObjCXX/arc-indirect.mm
20	You should CHECK for the load and appropriate call here. As written, this test would pass if you instead had changed the code to insert a null check.

This revision is now accepted and ready to land.Jun 26 2017, 8:34 AM

CHECK load and call

kastiglione marked an inline comment as done.Jun 26 2017, 10:53 AM

Thanks @rnk.

I don't have commit access; @compnerd, @rnk would either of you mind committing this? Thanks in advance!

SVN r306444

Path

Size

lib/

CodeGen/

4 lines

test/

CodeGenObjCXX/

21 lines

Show First 20 Lines • Show All 1,854 Lines • ▼ Show 20 Lines	if (Qualifiers::ObjCLifetime lt = qs.getObjCLifetime()) {
assert(&D == method->getSelfDecl());		assert(&D == method->getSelfDecl());
assert(lt == Qualifiers::OCL_Strong);		assert(lt == Qualifiers::OCL_Strong);
assert(qs.hasConst());		assert(qs.hasConst());
assert(method->getMethodFamily() != OMF_init);		assert(method->getMethodFamily() != OMF_init);
(void) method;		(void) method;
lt = Qualifiers::OCL_ExplicitNone;		lt = Qualifiers::OCL_ExplicitNone;
}		}

		// Load objects passed indirectly.
		if (Arg.isIndirect() && !ArgVal)
		ArgVal = Builder.CreateLoad(DeclPtr);

if (lt == Qualifiers::OCL_Strong) {		if (lt == Qualifiers::OCL_Strong) {
if (!isConsumed) {		if (!isConsumed) {
if (CGM.getCodeGenOpts().OptimizationLevel == 0) {		if (CGM.getCodeGenOpts().OptimizationLevel == 0) {
// use objc_storeStrong(&dest, value) for retaining the		// use objc_storeStrong(&dest, value) for retaining the
// object. But first, store a null into 'dest' because		// object. But first, store a null into 'dest' because
// objc_storeStrong attempts to release its old value.		// objc_storeStrong attempts to release its old value.
llvm::Value *Null = CGM.EmitNullConstant(D.getType());		llvm::Value *Null = CGM.EmitNullConstant(D.getType());
EmitStoreOfScalar(Null, lv, /* isInitialization */ true);		EmitStoreOfScalar(Null, lv, /* isInitialization */ true);
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines

				// RUN: %clang_cc1 -std=c++11 -triple i686-unknown-windows-msvc -fobjc-runtime=gnustep -fobjc-arc -Wno-objc-root-class -emit-llvm -o - %s \| FileCheck -check-prefixes CHECK,CHECK-GNUSTEP %s
				// RUN: %clang_cc1 -std=c++11 -triple i686-unknown-windows-msvc -fobjc-runtime=macosx -fobjc-arc -Wno-objc-root-class -emit-llvm -o - %s \| FileCheck -check-prefixes CHECK,CHECK-DARWIN %s
				// RUN: %clang_cc1 -std=c++11 -triple i686-unknown-windows-msvc -fobjc-runtime=ios -fobjc-arc -Wno-objc-root-class -emit-llvm -o - %s \| FileCheck -check-prefixes CHECK,CHECK-DARWIN %s

				// non trivially copyable, forces inalloca
				struct S {
				S(const S &s) {}
				};

				@interface C
				@end
				@implementation C
				- (void)object:(id)obj struct:(S)s {
				}
				@end

				// CHECK-GNUSTEP: define internal void @_i_C__object_struct_(<{ %0, i8, i8, %struct.S, [3 x i8] }> inalloca)
				// CHECK-DARWIN: define internal void @"\01-[C object:struct:]"(<{ %0, i8, i8, %struct.S, [3 x i8] }> inalloca)
				// CHECK: %obj = getelementptr inbounds <{ %0, i8, i8, %struct.S, [3 x i8] }>, <{ %0, i8, i8, %struct.S, [3 x i8] }>* %0, i32 0, i32 2
				// CHECK: %1 = load i8, i8* %obj, align 4
				rnkUnsubmitted Done Reply Inline Actions You should CHECK for the load and appropriate call here. As written, this test would pass if you instead had changed the code to insert a null check. rnk: You should CHECK for the load and appropriate call here. As written, this test would pass if…
				// CHECK: call void @objc_storeStrong(i8** %obj, i8* %1)