This is an archive of the discontinued LLVM Phabricator instance.

Differential D34534

[libcxx] [test] Fix MSVC warning C4242 "conversion from 'int' to 'const char', possible loss of data".
ClosedPublic

Authored by STL_MSFT on Jun 22 2017, 2:30 PM.

Details

Reviewers
EricWF
mclow.lists
STL_MSFT
Summary

[libcxx] [test] Fix MSVC warning C4242 "conversion from 'int' to 'const char', possible loss of data".

Diff Detail

Event Timeline

STL_MSFT created this revision.Jun 22 2017, 2:30 PM
STL_MSFT added a comment.Jul 10 2017, 1:18 PM

As I've made this exact change in other tests before, I'll commit this soon-ish if there are no comments or objections.

STL_MSFT mentioned this in rL308532: [libcxx] [test] Fix MSVC warning C4242 "conversion from 'int' to 'const char'….Jul 19 2017, 3:03 PM
STL_MSFT accepted this revision.Jul 19 2017, 3:15 PM
This revision is now accepted and ready to land.Jul 19 2017, 3:15 PM
STL_MSFT closed this revision.Jul 19 2017, 3:15 PM

Revision Contents

PathSize
test/
std/
input.output/
iostream.format/
ext.manip/
2 lines
input.streams/
istream.formatted/
istream_extractors/
2 lines

Diff 103639

test/std/input.output/iostream.format/ext.manip/put_money.pass.cpp

Show All 34 Lines
protected: protected:
virtual typename base::int_type virtual typename base::int_type
overflow(typename base::int_type __c = base::traits_type::eof()) overflow(typename base::int_type __c = base::traits_type::eof())
{ {
if (__c != base::traits_type::eof()) if (__c != base::traits_type::eof())
{ {
int n = str_.size(); int n = str_.size();
str_.push_back(__c); str_.push_back(static_cast<CharT>(__c));
str_.resize(str_.capacity()); str_.resize(str_.capacity());
base::setp(const_cast<CharT*>(str_.data()), base::setp(const_cast<CharT*>(str_.data()),
const_cast<CharT*>(str_.data() + str_.size())); const_cast<CharT*>(str_.data() + str_.size()));
base::pbump(n+1); base::pbump(n+1);
} }
return __c; return __c;
} }
}; };
Show All 40 Lines

test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extractors/streambuf.pass.cpp

Show All 40 Lines
protected: protected:
virtual typename base::int_type virtual typename base::int_type
overflow(typename base::int_type __c = base::traits_type::eof()) overflow(typename base::int_type __c = base::traits_type::eof())
{ {
if (__c != base::traits_type::eof()) if (__c != base::traits_type::eof())
{ {
int n = str_.size(); int n = str_.size();
str_.push_back(__c); str_.push_back(static_cast<CharT>(__c));
str_.resize(str_.capacity()); str_.resize(str_.capacity());
base::setp(const_cast<CharT*>(str_.data()), base::setp(const_cast<CharT*>(str_.data()),
const_cast<CharT*>(str_.data() + str_.size())); const_cast<CharT*>(str_.data() + str_.size()));
base::pbump(n+1); base::pbump(n+1);
} }
return __c; return __c;
} }
}; };
Show All 12 Lines